bttv (and others) conflict with i2c from CVS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



I need/want to run i2c from CVS (because I need lm_sensors from CVS in
order to support my motherboard) but once those patches are applied to
the kernel, it breaks compilation of all the v4l drivers (and at least
one framebuffer driver, possibly other components.)

I have been using 2.4.21-rc7-ac1, but 2.4.21 is just out and appears the
same so I'm sure this still applies.

I managed to mangle bttv-if.c and tvmixer.c such that it compiles and it
even seems to run fine co-existing peacefully with i2c/lm_sensors.

However, I'm pretty sure what I did was bad, perhaps someone could
comment on how bad?  Are there plans to update the v4l drivers to use
the new i2c?  I imagine doing so before i2c is released (probably as
2.8.0) is not on anyone's todo list.  

Anyway, what I changed was in bttv-if.c I commented out this in the
initialization of bttv_i2c_adap_template:
	.inc_use           = bttv_inc_use,
	.dec_use           = bttv_dec_use,

In tvmixer.c I removed these bits:

	if (client->adapter->inc_use)
		client->adapter->inc_use(client->adapter);

	if (client->adapter->dec_use)
		client->adapter->dec_use(client->adapter);

Could anyone fill me in on what the above code does?  Does it simply
increment the usage count for the module (bttv, or i2c-core or what?)


Thanks,
Aran





[Index of Archives]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [Linux USB]

Powered by Linux