Re: TVAudio Patch for saa7134 Mar 13 snapshot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Gerd,

I've just tried your patch for tvaudio, and it works fine on my FV2K.
Please apply.

This patch has the effect of unmuting audio in xawtv as soon as the
channel is enabled (and muting on exiting xawtv). So static will be heard
if the signal is really weak or if there's no transmission.

The previous case of using the tvaudio thread would keep audio muted if
there isn't a strong audio carrier.  I guess unmuting only when a strong
carrier is detected is easier on the ears, though it might not be the
correct behavior.

I'll live with the static since at least I know tv audio is working :)

NB: the patch does not solve the problem of mplayer audio not unmuting, 
    but that is a v4l1 compatibility issue anyway.

T.C.
----
Wan Tat Chee (Lecturer)
School of Computer Science, Univ. Science Malaysia,
11800 Minden, Penang, Malaysia.          Ofc Ph: +604 653-3888 x 3617
Internet: tcwan@xxxxxxxxx            Web: http://nrg.cs.usm.my/~tcwan
GPG Key : http://nrg.cs.usm.my/~tcwan/tcw_gpg.asc
F'print : FB0F CED7 85A5 ECF9 DEF0  50E8 A550 A0D2 8638 B1EB

On Mon, 17 Mar 2003, Gerd Knorr wrote:

> Wrong.  The 7130 doesn't support tv audio decoding, thus there is
> no point in starting the (useless) thread which programms the
> tv audio decoding unit.
> 
> The thread likely just has the side effect that it unmutes the sound
> once the carrier scan is finished, so the non-thread case needs a
> way to unmute too.  Does the patch below work?
> 
>   Gerd
> 
> --- saa7134-tvaudio.c~	2003-02-28 11:15:52.000000000 +0100
> +++ saa7134-tvaudio.c	2003-03-17 18:00:13.569637456 +0100
> @@ -748,6 +748,9 @@
>  	if (dev->thread.task) {
>  		dev->thread.scan2++;
>  		wake_up_interruptible(&dev->thread.wq);
> +	} else {
> +		dev->automute = 0;
> +		saa7134_tvaudio_setmute(dev);
>  	}
>  	return 0;
>  }
> 





[Index of Archives]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [Linux USB]

Powered by Linux