On Mon, Mar 17, 2003 at 12:41:02PM +0800, Wan Tat Chee wrote:
> Gerd,
>
> Enclosed is a patch to fix missing TV Audio on SAA7130 class (FV2K)
> cards. It's a missing case statement in the thread initialization code.
> switch (dev->pci->device) {
> + case PCI_DEVICE_ID_PHILIPS_SAA7130:
> case PCI_DEVICE_ID_PHILIPS_SAA7134:
> my_thread = tvaudio_thread;
> break;
Wrong. The 7130 doesn't support tv audio decoding, thus there is
no point in starting the (useless) thread which programms the
tv audio decoding unit.
The thread likely just has the side effect that it unmutes the sound
once the carrier scan is finished, so the non-thread case needs a
way to unmute too. Does the patch below work?
Gerd
--- saa7134-tvaudio.c~ 2003-02-28 11:15:52.000000000 +0100
+++ saa7134-tvaudio.c 2003-03-17 18:00:13.569637456 +0100
@@ -748,6 +748,9 @@
if (dev->thread.task) {
dev->thread.scan2++;
wake_up_interruptible(&dev->thread.wq);
+ } else {
+ dev->automute = 0;
+ saa7134_tvaudio_setmute(dev);
}
return 0;
}
