Re: bttv - Radio sound quirks bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Gerd Knorr wrote:
> 
> David Balazic <david.balazic@xxxxxxxxx> writes:
> 
> >       v = 400*16;  //                                <--- here
> >       bttv_call_i2c_clients(btv,VIDIOCSFREQ,&v); //  <--- and here
> >       bttv_call_i2c_clients(btv,AUDC_SET_RADIO,&btv->tuner_type);
> 
> > Why are those two lines there ?
> 
> Because it will stop working otherwise.

I noticed :-)

> 
> > They try to set the tuner to 400 MHz, but that is illegal for radio
> > and is flaged as such deeper in the code.
> 
> the tuner is switched to radio mode afterwards.

Except if it is already in radio mode, then it prints the error message.
Can't the driver check if the tuner is already in radio mode and then
not execute this line ?

I will do some more research on my own , to figure out what can and what
can't be done.

( browsing unknown code for an unknown API is fun ! :-)

> 
> > Does anybody maintain this driver ?
> 
> yes.
> 
>   Gerd
> 
> --
> sigfault
> 
> --
> video4linux-list mailing list
> Unsubscribe mailto:video4linux-list-request@xxxxxxxxxx?subject=unsubscribe
> https://www.redhat.com/mailman/listinfo/video4linux-list


-- 
David Balazic
--------------
"Be excellent to each other." - Bill S. Preston, Esq., & "Ted" Theodore
Logan
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
- - -




[Index of Archives]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [Linux USB]

Powered by Linux