On Tue, Nov 26, 2002 at 09:02:21PM +0100, Gunther Mayer wrote:
> Edward Wohlman wrote:
> >
> > Ok, still can't get it running
> > here's my output
> >
> > Xandros:~$ dmesg|grep -e tv -e tuner
> > bttv: driver version 0.7.91 loaded
> > bttv: using 2 buffers with 2080k (4160k total) for capture
> > bttv: Host bridge is VIA Technologies, Inc. VT8363/8365 [KT133/KM133]
> > bttv: Bt8xx card found (0).
> > bttv0: Bt878 (rev 17) at 00:09.0, irq:5, latency :32, memory: 0xeb002000
> > bttv0: subsystem: fafe:ffffc0fe (UNKNOWN)
> ^^^^^^^^^^^^^
> This subsystem ID indicates faulty hardware
> (should be 11bd:0012 os similar).
> Does it work in Windows?
This subsystem ID also indicates that bttv has some signedness problems.
Gerd, if you do not want to change cardid signedness in bttv_get_cardinfo() API,
just change only cardid definition in bttvp.h.
Thanks,
Petr Vandrovec
vandrove@xxxxxxxxxx
diff -urdN linux/drivers/media/video/bttv-if.c linux/drivers/media/video/bttv-if.c
--- linux/drivers/media/video/bttv-if.c 2002-11-25 13:33:26.000000000 +0000
+++ linux/drivers/media/video/bttv-if.c 2002-11-26 19:38:15.000000000 +0000
@@ -54,7 +54,7 @@
/* gpio ports (IR for example) */
/* see bttv.h for comments */
-int bttv_get_cardinfo(unsigned int card, int *type, int *cardid)
+int bttv_get_cardinfo(unsigned int card, int *type, unsigned int *cardid)
{
if (card >= bttv_num) {
return -1;
diff -urdN linux/drivers/media/video/bttv.h linux/drivers/media/video/bttv.h
--- linux/drivers/media/video/bttv.h 2002-11-25 13:33:26.000000000 +0000
+++ linux/drivers/media/video/bttv.h 2002-11-26 19:37:07.000000000 +0000
@@ -191,7 +191,7 @@
for possible values see lines below beginning with #define BTTV_UNKNOWN
returns negative value if error occurred
*/
-extern int bttv_get_cardinfo(unsigned int card, int *type, int *cardid);
+extern int bttv_get_cardinfo(unsigned int card, int *type, unsigned int *cardid);
extern struct pci_dev* bttv_get_pcidev(unsigned int card);
/* obsolete, use bttv_get_cardinfo instead */
diff -urdN linux/drivers/media/video/bttvp.h linux/drivers/media/video/bttvp.h
--- linux/drivers/media/video/bttvp.h 2002-11-25 13:33:32.000000000 +0000
+++ linux/drivers/media/video/bttvp.h 2002-11-26 19:36:44.000000000 +0000
@@ -255,7 +255,7 @@
/* card configuration info */
unsigned int nr; /* dev nr (for printk("bttv%d: ..."); */
char name[8]; /* dev name */
- int cardid; /* pci subsystem id (bt878 based ones) */
+ unsigned int cardid; /* pci subsystem id (bt878 based ones) */
int type; /* card type (pointer into tvcards[]) */
int tuner_type; /* tuner chip type */
struct bttv_pll_info pll;
