Re: Re: v4l2 api

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Gerd Knorr wrote:

* struct tuner: add some type field here too? For radio/tv/...?
Doesn't V4L2_TUNER_CAP_LOW cover that already?

We do need a 'mode' field in v4l2_frequency for that, I think. That field could also be used for setting spectrum inversion for ATSC, antenna polarization for sat, etc...

/* compressed formats */
#define V4L2_PIX_FMT_MJPEG    v4l2_fourcc('M','J','P','G') /* Motion-JPEG   */
In addition to that, I'd still like to see:

#define V4L2_PIX_FMT_JPEG    v4l2_fourcc('J','P','E','G') /* JFIF JPEG   */


#define VIDIOC_TRY_FMT      	_IOW  ('V', 63, struct v4l2_format)

Shouldn't that be:

#define VIDIOC_TRY_FMT      	_IOWR  ('V', 64, struct v4l2_format)


Other than that, I'm pretty happy with the API now. Thanks for your hard work (you too Michael)!

--
Mark McClelland
mark@xxxxxxxxxxxxxxxx






[Index of Archives]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [Linux USB]

Powered by Linux