On Wed, 6 Mar 2002, Wan Tat Chee wrote:
> Hi Gerd,
>
> I've managed to get the FlyVideo2000 External Audio In working. Enclosed
> is a patch against saa7134-20020219.tar.gz to support switching between
> TV Tuner audio and External Audio In. Details below.
>
> Thanks to Gert Vervoort for his kind assistance in explaining the
> difference between SAA7134 and SAA7130 to me.
>
I was thinking about the saa7134-0.1.5 patch over the weekend, and
wondering about how best to proceed as I'd like to make audio mute/unmute
work for FlyVideo2000 (FV2K).
Implementing audio muting for FV2K is quite simple really. Switch audio
to LINE1 on mute, switch back to LINE2 on unmute.
It appears that the amux_tuner and amux_extern variables introduced in
0.1.5 when I first tried to add FV2K support is pretty much redundant, as
the audio path config. for FV2K is very different from the SAA7134 based
boards. Consequently, every audio path switch routine would have to test
for SAA7134 vs. FV2K / SAA7130 (?).
So, pending an official update to saa7134 from Gerd, I'd like to get a
sense of whether the following is appropriate:
1. remove amux_tuner and amux_extern, make the audio path selection
between TV, LINE1, and LINE2 part of the saa7134_tvaudio_setinput()
routine, as was in saa7134-0.1.4. This means the introduction of
an equivalent routine for FV2K support, and an if..then...else
check every time audio path functions are called.
2. Introduce function pointers in struct saa7134_board{} to access
appropriate audio path switching routines (tvaudio_setinput() and
tvaudio_setmute()) for SAA7134 vs. FV2K boards. No if..then..else
penalty, but messier dealing with function pointers.
3. Introduce a new kernel module target to saa7134-0.1.x package
saa7130.o (?) for FV2K specific usage.
(only the audio parts are different, the rest should be the same)
4. Incidentally, I wonder if the FV2K implementation using external
audio mux generic to all SAA7130 based designs?
Comments?
T.C.
----
Wan Tat Chee (Lecturer)
School of Computer Science, Univ. Science Malaysia,
11800 Minden, Penang, Malaysia. Ofc Ph: +604 657-7888 x 3617
Internet: tcwan@xxxxxxxxx Web: http://nrg.cs.usm.my/~tcwan
GPG Key : http://nrg.cs.usm.my/~tcwan/tcw_gpg.asc
F'print : FB0F CED7 85A5 ECF9 DEF0 50E8 A550 A0D2 8638 B1EB
