On Wed, 26 Sep 2001, Stephen Davies wrote:
> 1) Select composite input - video and audio switches correctly
> 2) mute and unmute - you will incorrectly hear sound from the tuner again
> (even though the composite video is still displayed).
Hi Gerd et al,
I'm trying to find this bug.
But I don't think that I understand this code:
case AUDC_SET_INPUT:
/* scart switching
- IN1 is often used for external input
- Hauppauge uses IN2 for the radio */
dprintk(KERN_DEBUG "msp34xx: AUDC_SET_INPUT(%d)\n",*sarg);
msp->scart = 0;
switch (*sarg) {
case AUDIO_RADIO:
msp3400c_set_scart(client,SCART_IN2,0);
msp3400c_write(client,I2C_MSP3400C_DFP,0x000d,0x1900);
msp3400c_setstereo(client,msp->stereo);
break;
case AUDIO_EXTERN:
msp->scart = 1;
msp3400c_set_scart(client,SCART_IN1,0);
msp3400c_write(client,I2C_MSP3400C_DFP,0x000d,0x1900);
msp3400c_setstereo(client,msp->stereo);
break;
case AUDIO_TUNER:
msp3400c_setstereo(client,msp->stereo);
break;
default:
if (*sarg & AUDIO_MUTE)
msp3400c_set_scart(client,SCART_MUTE,0);
break;
}
The *sarg&AUDIO_MUTE will match both AUDIO_MUTE (0x80) and AUDIO_UNMUTE
(0x81). As far as I can see both will be handled identically.
Its also confusing that the MUTE/UNMUTE is handled completely different in
v4l2 and v4l - for v4l muting is about setting the volume to 0...
Yours in puzzlement,
Steve
