Hi Steve, On Tue, 2003-09-09 at 06:39, Steve Tell wrote: [..] > This computation of maxdiff in the setup code is bogus because of integer > overflow in lavtools/audiolib.c: > > maxdiff = TIME_STAMP_TOL*audio_byte_rate/1000000; > (TIME_STAMP_TOL is 100000 and audio_byte_rate is 176400. > Same in both mjpegtools-1.6.1 and -1.6.1.90). > > forcing it to floating point and back makes everything work and I can > capture video + audio nicely (patch attached): > > maxdiff = (int) (((double)TIME_STAMP_TOL)*audio_byte_rate/1000000.0); > > Which begs the question, how come audio in lavrec ever worked for anyone? > I guess I ought to get onto the mjpegtools list to report this... Hm, good question. I'll make sure the patch (probably with a 64bit int cast instead of a double cast) comes into the next release candidate for 1.6.2. Thanks! Ronald -- Ronald Bultje <rbultje@xxxxxxxxxxxxxxxxxxx>
