Re: saa7134 - who is fine on 2.6.0-test3?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



I am trying 2.6test4 with the latest patch and some applications (certainly zapping and tvtime but maybe others) have trouble, because they don't set the memory type field in the buffer request/query ioctls. Fortunately, this is trivial to fix, here is a patch for tvtime.

On a vanilla 2.6test4, even these broken applications work well.

Regards,
--
Jindrich Makovicka
--- videoinput.c.~1.90.~	1970-01-01 01:00:01.000000000 +0100
+++ videoinput.c	2003-08-26 15:59:40.000000000 +0200
@@ -794,6 +794,7 @@
          */
         req.count = 4;
         req.type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+	req.memory = V4L2_MEMORY_MMAP;
 
         if( ioctl( vidin->grab_fd, VIDIOC_REQBUFS, &req ) < 0 ) {
             fprintf( stderr, "videoinput: Card failed to allocate capture buffers: %s\n",
@@ -826,6 +827,7 @@
 
             vidbuf->index = i;
             vidbuf->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
+	    vidbuf->memory = V4L2_MEMORY_MMAP;
             if( ioctl( vidin->grab_fd, VIDIOC_QUERYBUF, vidbuf ) < 0 ) {
                 fprintf( stderr, "videoinput: Can't get information about buffer %d: %s.\n",
                          i, strerror( errno ) );

[Index of Archives]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [Linux USB]

Powered by Linux