saa7134-20030521 snapshot hangs in modprobe -r

[Tom Zoerner <tomzo@xxxxxxxxxx>]

Hi,

After upgrading from 20030507 to 20030521 snapshot, the saa7134 module
hangs when I try to unload it.  A diff between the versions quickly
showed a suspicious new for(;;) loop.  Adding the following two checks
for the exit flag fixed the problem.  I'd be surprised if I'm the only
one who ran into this; pardon me if it has been reported before.

I should also note that audio handling during channel switches has
become worse in this snapshot.  Appearently audio is muted too late
so that there's often a loud crackling noise upon switches. I have
a Typhoon 90031 card with SAA7134 and no extra audio chip.

bye,
-tom

--- saa7134-tvaudio.c.orig      Wed May 14 12:20:15 2003
+++ saa7134-tvaudio.c   Sat May 31 13:16:16 2003
@@ -554,8 +554,12 @@
                dev->tvaudio = &tvaudio[audio];

                for (;;) {
+                       if (dev->thread.exit || signal_pending(current))
+                               goto done;
                        if (tvaudio_sleep(dev,3*HZ))
                                break;
+                       if (dev->thread.exit || signal_pending(current))
+                               goto done;
                        if (UNSET == dev->thread.mode) {
                                rx = tvaudio_getstereo(dev,&tvaudio[i]);
                                mode = saa7134_tvaudio_rx2mode(rx);