-----FW: <XFMail.20030521220929.f.duncan.m.haldane@xxxxxxxxxxxxxxxx>----- Hi Alan, Gerd Knorr noticed a small use of floating point math in the cpia driver updates for 2.5.x I sent you a while ago, and this is not allowed in the kernel. This was in some code taken essentially verbatim from the Windows cpia driver released under the GPL by STM inc. that had been incorporated in the later versions of the cpia driver at sourceforge. It turns out that the use of floating point was quite inessential, and I've reimplemented the couple of lines of code involved in integer arithmetic. Patch against 2.5.69 attached. Regards, Duncan Haldane ------------------------------------------------- On 20-May-2003 Andrew Morton wrote: > Peter Pregler <Peter_Pregler@xxxxxxxxx> wrote: >> >> On Mon, 19 May 2003 12:56:43 +0200 >> Gerd Knorr <kraxel@xxxxxxxxxxx> wrote: >> >> > Hi, >> > >> > cpia driver does fp math in kernel (set_flicker function). That isn't >> > allowed, please fix. >> >> Someone has 'ported' a windows-driver functionality directly to the >> kernel. It is in our cvs-tree but not in the 2.4.x tree. Don't know who >> sent this upstreams for 2.5.x. Thanx for the info. >> > > That would be Alan, who on 28 Oct last year submitted "cpia update from > maintainer". > > Alan, it's using floating point in set_flicker(). The 2.4 version doesn't > seem to have FP in it. To whom do we talk? > > Thanks.
Attachment:
patch-2.5.69-cpia
Description: patch-2.5.69-cpia
