> > There are some oddments that I'd move into headers, > > For example? I tried to keep the header as small as possible including > necessary defines and main structures only. Linux people tend to put the macros and debug stuff into headers as well. Its just style stuff - and not a claim there is a "right" style just its the kernel style > thread 1 - read image > thread 2 - change picture size > > There's not a particular reason behind that. I used that procedure > to avoid the settings to be changed if the requested frames aren't still > captured. I can remove the incriminated lines of code (<5) if the policy > has to be different. Ah sorry. I was looking for locking, but in fact you defer the change. > Other bits: > For things that really can't happen we normally use BUG(). > > I don't understand, sorry.. If you've got something that cannot happen, we have a function called BUG() which prints out the file/line and then a stack trace. Users tend not to report "Odd.. this can't occur" messages, but do report stack traces 8) > What ahout the /proc interface? Can I keep it? I don't see a problem for now. Gerd's final call not mine. The sysfs stuff in 2.5 eventually should let people do far more, but lots has yet to migrate to it. > I will send you the driver by email as soon as I totally "clean" it and > the ovsensor module is included in the kernel 2.5. Thanks Alan
