On Mon, Feb 10, 2003 at 09:53:53PM +0100, Gerd Knorr wrote: > Brian Craft <bcboy@xxxxxxxxxxxxxxxxxx> writes: > > > No -- only if it's suppported by your video board, and your video driver, and > > you actually like the scaled video it produces. If any of these are false you > > won't be using _NET_WM_STATE_FULLSCREEN, and then it doesn't work correctly. > > Not surprising if you don't use _NET_WM_STATE_FULLSCREEN. There is no > other sane way to tell the WindowManager that you want enter > fullscreen mode. What do you expect? And what is wrong with > _NET_WM_STATE_FULLSCREEN? I'm not sure I follow this, looking at the code. _NET_WM_STATE_FULLSCREEN is invoked only if the video mode is *not* being set. I don't have docs for this state, but it appears that it serves to invoke xvideo via the window manager. The point of the patch was that when *not* using xvideo (because in some cases it provides very poor quality output), then metacity and xawtv don't agree on the window positioning. Am I missing something here? In x11/xt.c, do_fullscreen() bails out after setting _NET_WM_STATE_FULLSCREEN via wm_fullscreen, before the video mode code is invoked -- which is where the patch applies. b.c.
