On Mon, Jan 20, 2003 at 12:33:02AM +0100, Gunther Mayer wrote:
> Hi,
> this patch includes the latest "make CARDLIST" and Cards patch, plus
> - new card: Pace TV & Radio Card
> - fix radio for some MSP34xx cards, e.g. Voodoo200, Pace Tv & Radio
> It didn't work here for both "simple" settings:
> - simple=0: Volume was disabled in msp_wake_thread, but 3400c_thread
> failed to enable
But the fix is wrong: It is the job of the thread to enable the volume
when it is done with the tv audio carrier scan (because we want to do
the carrier scan muted, otherwise channel switches will cause crazy
sounds). Patch below.
> - simple=1: Besides correcting routing via scart towards decoding
> ourselves,
> this needed "omit reset" and "set mode et al." for
> 3410_thread, too.
Same issue. If the thread doesn't manage to setup the radio it should
be fixed there and not workarounded somewhere else.
> - Printk a warning when msp3410d thread autodetect fails
> (essentially autodetect on Voodoo200 fails and you should load with
> "simple=0"
Hmm. That one might flood your log with false alarms. Sometimes it is
perfectly legal for the scan to fail, for example if there is no signal.
Don't like that very much ...
Gerd
==============================[ cut here ]==============================
--- bttv-0.7.103/driver/msp3400.c~ 2003-01-10 10:55:09.000000000 +0100
+++ bttv-0.7.103/driver/msp3400.c 2003-01-24 17:36:24.000000000 +0100
@@ -783,8 +783,12 @@
goto done;
if (VIDEO_MODE_RADIO == msp->norm ||
- MSP_MODE_EXTERN == msp->mode)
- continue; /* nothing to do */
+ MSP_MODE_EXTERN == msp->mode) {
+ /* no carrier scan, just unmute */
+ msp3400c_setvolume(client, msp->muted,
+ msp->left, msp->right);
+ continue;
+ }
msp->active = 1;
