Re: Are *all* 2.4.x v4l drivers now broken?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Duncan Haldane <f.duncan.m.haldane@xxxxxxxxxxxxxxxx> writes:

> Hi 
> 
> I tested Gerd's patch to fix the deadlock when old-v4l-interface
> drivers get hot unplugged -- It doesn't quite do the job because
> vfl->owner can't get its module count decreased if vfl=NULL after
> the cleanup.  The solution is to store a pointer to vfl->owner
> before calling vfl->close, then later do a __MOD_DEC_USE_COUNT with
> it, rather than with vfl->owner, which may be history.
> 
> I attach a (I think) corrected patch.  (tested).

Good spotting, thanks.

> (Hopefully the 2.4.21 kernel can get all the improvements in the
> cpia driver, so this type of maintenance can end ...)

I've just sent a bunch of 2.5.x patches to linus+lkml, now I'm going
to prepare updates for 2.4.x to get stuff updated in 2.4.21.

Next thing is to go back my backlog, I have quite some stuff from last
year pending which waits for being looked at / get fixed ...

  Gerd

-- 
Weil die späten Diskussionen nicht mal mehr den Rotwein lohnen.
				-- Wacholder in "Melanie"





[Index of Archives]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [Linux USB]

Powered by Linux