Peter Schlaf wrote:
Gerd Knorr wrote:
We do need a 'mode' field in v4l2_frequency for that, I think. That
field could also be used for setting spectrum inversion for ATSC,
antenna polarization for sat, etc...
I added a type field to the tuner struct, so we can add support for
ATSC+stuff later. Also plenty of "reserved" fields to v4l2_frequency
...
For the implementation of selection the antenna polarization and other
satellite related switches it is IMHO better to have an own struct,
e.g. struct v4l2_antenna and two ioctl calls for reading and setting
this struct. This would make the API more cleaner.
You're probably right about that. Some other things could be added to
that struct too, like rotator control. I think we should wait until we
have a good selection of hardware to study before adding any of that to
the API, though (the same goes for ATSC for the most part). These things
can be implemented as driver-specific ioctls or even v4l2 controls at
first, and then added to the official API once we have more experience.
--
Mark McClelland
mark@xxxxxxxxxxxxxxxx