Wan Tat Chee wrote: > > Hi, > > As for S-Video luma-control. I find that set_tvnorm() is only called > explicitly when selecting "TV Norm" in saa7134-0.1.5. Something needs to > be done in VIDIOC_S_INPUT to triggle the S-Video luma-control properly. This might explain what I saw last wednesday, when playing around with different CVBS/S-Video PAL/NTSC settings. Although I didn't see it with a quick test yesterday, I will do some more testing tomorrow. There are currently 2 situations which require updating of the luma control register: - switching input (CVBS/TV vs S-Video) - switching video norm (PAL/NTSC vs SECAM) > The following patch fixes the problem, but I think it's a little > 'expensive' since set_tvnorm() is called every time we switch video > inputs. Note: it must be called after video_mux() as it depends on > dev->ctl_input being set first. The luma-control stuff should probably be > split out from set_tvnorm()? Why is it 'expensive'? Switching between inputs (TV, CVBS, S-Video) is not something you do very frequently. But indeed, with set_tvnorm() a lot of settings are done which are not really required for just setting the luma control register. Gert > -------------- saa7134-0.1.5-fv2k-svideo.diff --------- > diff -Naur saa7134-0.1.5/saa7134-video.c saa7134-0.1.5-fv2k/saa7134-video.c > --- saa7134-0.1.5/saa7134-video.c Tue Mar 26 14:04:43 2002 > +++ saa7134-0.1.5-fv2k/saa7134-video.c Tue Mar 26 14:01:39 2002 > @@ -1114,6 +1114,7 @@ > return -EINVAL; > down(&dev->lock); > video_mux(dev,*i); > + set_tvnorm(dev,dev->tvnorm); > up(&dev->lock); > return 0; > } > > -------- cut here ----------
