Problems with saa7134-0.1.5 and kernel 2.4.19-pre4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi,

I've managed to compile the "official" saa7134-0.1.5 release against
2.4.19-pre4 with all the 0?*diff patches. However, I find that it
doesn't work as reliably compared to the older March 11 snapshot
compiled against 2.4.19-pre3ac3.

I've backported the S-Video support to the Mar 11 snapshot (ignoring
the ioctl changes) and it works fine.

The issues:

1. With saa7134-0.1.5/2.4.19-pre4, XWindows 4.1, NVidia driver
   (for Xv support), xawtv TV channel changes are not working. It works
   fine running with just fbtv on rivafb. There seems to be some
   interaction between pre4 and XWindows. I don't have this problem
   in 2.4.19-pre3ac3.

2. S-Video input gives a grainy picture with the saa7134-0.1.5/2.4.19-pre4
   config. This does not occur with the saa7134-mar11-snap/2.4.19-pre3ac3.
   What I mean by grainy is that the color intensity seems to be
   modulating along the scan line.

   The brightness level for S-Video is also less than for Composite
   Input for the same setting, but I suppose it's not so critical.

3. Updating the saa7134-cards.c cards entry is not reflected properly
   via 'v4lctl list' after a 'rmmod saa7134 tuner v4l2-common ...' while
   running under XWindows. E.g., while modprobing the official
   saa7134-0.1.5 module vs. my modified saa7134-0.1.5-fv2k module, the
   availability of the S-Video input is not updated properly.

   This does not occur in console mode while not running XWindows.
   i.e., I can switch saa7134 modules and get the correct Video inputs
   list when in console mode, but not in XWindows.

   Is the v4l ioctls flushed properly when using rmmod under XWindows?
   (lsmod indicates that the modules are removed).

4. vbi support on FV2K still not functional. 'alevtd -d' after I've tuned
   into the correct TV channel complains about "insufficient number of
   periods..."

   What am I missing?

5. I've fixed up the source inputs for FV2K, for Composite and S-Video.
   Also included is the external audio muting patches for FV2K.

----- saa7134-0.1.5-fv2k.diff ---------------------------------------
diff -Naur saa7134-0.1.5/saa7134-cards.c saa7134-0.1.5-fv2k/saa7134-cards.c
--- saa7134-0.1.5/saa7134-cards.c	Wed Mar 20 12:49:13 2002
+++ saa7134-0.1.5-fv2k/saa7134-cards.c	Sat Mar 23 01:20:42 2002
@@ -90,15 +90,23 @@
 		gpiomask:       0x6000,
 		inputs: {{
 			name: name_comp1,
-			vmux: 0,
+			vmux: 3,
 			amux: LINE2,
 			gpio: 0x4000,
+			ext_mute: 1,
+		},{
+			name: name_svideo,
+			vmux: 8,
+			amux: LINE2,
+			gpio: 0x4000,
+			ext_mute: 1,
 		},{
 			name: name_tv,
 			vmux: 1,
 			amux: LINE2,
 			gpio: 0x0000,
 			tv:   1,
+			ext_mute: 1,
 		}},
 	},
 	[SAA7134_BOARD_EMPRESS] = {
diff -Naur saa7134-0.1.5/saa7134-tvaudio.c saa7134-0.1.5-fv2k/saa7134-tvaudio.c
--- saa7134-0.1.5/saa7134-tvaudio.c	Mon Mar 11 10:17:23 2002
+++ saa7134-0.1.5-fv2k/saa7134-tvaudio.c	Fri Mar 22 05:53:34 2002
@@ -145,8 +145,17 @@

 void saa7134_tvaudio_setmute(struct saa7134_dev *dev)
 {
-	saa_writeb(SAA7134_AUDIO_MUTE_CTRL,
-		   (dev->ctl_mute || dev->automute) ? 0xff : 0xbb);
+	struct saa7134_input *in;
+	in = &card_in(dev,dev->ctl_input);
+	if (!in->ext_mute) {
+	  saa_writeb(SAA7134_AUDIO_MUTE_CTRL,
+		     (dev->ctl_mute || dev->automute) ? 0xff : 0xbb);
+	} else {
+	  if (dev->ctl_mute || dev->automute)
+	    saa_andorb(SAA7134_ANALOG_IO_SELECT, 0x07, 0x00); /* LINE1 */
+	  else
+	     saa7134_tvaudio_setinput(dev,in);
+	}
 }

 void saa7134_tvaudio_setinput(struct saa7134_dev *dev,
diff -Naur saa7134-0.1.5/saa7134.h saa7134-0.1.5-fv2k/saa7134.h
--- saa7134-0.1.5/saa7134.h	Tue Mar 19 11:52:33 2002
+++ saa7134-0.1.5-fv2k/saa7134.h	Fri Mar 22 05:54:10 2002
@@ -121,7 +121,7 @@
 	int                     vmux;
 	enum saa7134_audio_in   amux;
 	int                     gpio;
-	int                     tv:1;
+	int                     tv:1,ext_mute:1;
 };

 struct saa7134_board {
---------------------- cut here --------------------------------------

Regards,
T.C.
----
Wan Tat Chee (Lecturer)
School of Computer Science, Univ. Science Malaysia,
11800 Minden, Penang, Malaysia.          Ofc Ph: +604 657-7888 x 3617
Internet: tcwan@xxxxxxxxx            Web: http://nrg.cs.usm.my/~tcwan
GPG Key : http://nrg.cs.usm.my/~tcwan/tcw_gpg.asc
F'print :  FB0F CED7 85A5 ECF9 DEF0  50E8 A550 A0D2 8638 B1EB





[Index of Archives]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [Linux USB]

Powered by Linux