Alan Cox wrote: > > driver_bar(file, struct video_bar *b) > > { > > struct file_data *fh = file->priv_data; > > struct driver_data *drv = fh->driver_data; > > Why do you need those when you can pass them in ? I'd do it this way to keep stuff consistent with the file_operations functions. Of course file->priv_data can be passed in as void pointer instead. > > that's all. Is that really worth the effort? > > Im not sure, Linus thinks yes Hmm. Does it mean it is mandatory to get v4l2 into the kernel? Gerd -- Gerd Knorr <kraxel@xxxxxxxxxxx> -- SuSE Labs, Außenstelle Berlin