Re: API.html bug? (VIDEO_PALETTE YUV names again)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Alan Cox wrote:
> > 	driver_bar(file, struct video_bar *b)
> > 	{
> > 		struct file_data *fh = file->priv_data;
> > 		struct driver_data *drv = fh->driver_data;
>  
>  Why do you need those when you can pass them in ?

I'd do it this way to keep stuff consistent with the file_operations
functions.  Of course file->priv_data can be passed in as void pointer
instead.

> > that's all.  Is that really worth the effort?
>  
>  Im not sure, Linus thinks yes

Hmm.  Does it mean it is mandatory to get v4l2 into the kernel?

  Gerd

-- 
Gerd Knorr <kraxel@xxxxxxxxxxx>  --  SuSE Labs, Außenstelle Berlin





[Index of Archives]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [Linux USB]

Powered by Linux