Re: [V4L] races in v4l read + write in 2.4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



In lists.linux.v4l, you wrote:
> > As usual, this is just IMHO, but I think the idea of videodev.c was to
> > be a pretty lightweight wrapper, with the driver doing all the real
> > work.
> 
> The multiopen locking in videodev.c was a mistake. I actually fixed the 2.4
> read/write locking on most of the radio devices so removing it shouldnt be
> too tricky.

It is still impossible to support multiple opens as the driver's can't hook
data into file->private_data (neither directly nor indirectly) and therefore
can't disturgish the filehandles.

Justin's videodevX.c solves this in IMHO nice way.  It adds a second struct
with enhanced open/read/... hooks and a second pair of register/unregister
calls (v4l2 way of handing it).  Both old and new drivers can register and
get minor numbers below major 81.

Any chance to see this in 2.5.x (or even 2.4.x ?).

  Gerd

-- 
Protecting the children is a good way to get a lot of adults who cant
stand up for themselves.		-- seen in some sig on /.





[Index of Archives]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [Linux USB]

Powered by Linux