Re: [V4L] bttv2 color?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Anton Coetzee wrote:
> 
> Hi
> 
> I've been using an IxMicro TurboTV quite succesfully with v4l/bttv for a
> while. I've just built v4l2 to see if it improves mp1e capture (which it
> does!), but now the color is strange (saturation too high) - any ideas?
> anyone had similar problems?
> 
> Thanks
> 
> Anton Coetzee

Use vidpanel (available from http://www.thedirks.org/v4l2) to set up
defaults for the video.  Some other video apps do not set the defaults
properly.

Also, you can try the simple patch below (untested), which fixes the
comb filter... (apply with "patch -p 1 < bttv2_comb.patch" from within
the bttv2 directory)

-justin
diff -urN bttv2/bttv-driver.c /hotdrvb/v4l2/driver/bttv-driver.c
--- bttv2/bttv-driver.c	Fri Sep 15 11:20:28 2000
+++ /hotdrvb/v4l2/driver/bttv-driver.c	Sat Sep 16 10:20:09 2000
@@ -647,9 +647,9 @@
 	/* Some people say interpolation looks bad ... */
 	vtc = (width < 193) ? 2 : ((width < 385) ? 1 : 0);
 	if (width < 767)
-		btor(BT848_VSCALE_COMB, BT848_E_VSCALE_HI+off);
+		geo->comb=1;
 	else
-		btand(~BT848_VSCALE_COMB, BT848_E_VSCALE_HI+off);
+		geo->comb=0;
 #else
 	geo->vtc = 0;
 	geo->comb = 0;
@@ -670,6 +670,10 @@
 	}
 	geo->format = formats[i].bt848fmt;
 	geo->bswap = formats[i].bswap;
+	if(formats[i].packed==0)
+	{
+		geo->comb=1;
+	}
 	if(bigendian && geo->format == BT848_COLOR_FMT_E_RGB32)
 	{
 		geo->bswap^=1; // bswap
@@ -698,6 +702,10 @@
 	btwrite(geo->vdelay, BT848_E_VDELAY_LO+off);
 	btwrite(geo->crop, BT848_E_CROP+off);
 	btaor(geo->uvswap, 0xef, BT848_E_CONTROL+off);
+	if(geo->comb)
+		btor(BT848_VSCALE_COMB, BT848_E_VSCALE_HI+off);
+	else
+		btand(~BT848_VSCALE_COMB, BT848_E_VSCALE_HI+off);
 	if(odd)
 	{
 		btaor(geo->format<<4, 0x0f, BT848_COLOR_FMT);

[Index of Archives]     [Linux DVB]     [Video Disk Recorder]     [Asterisk]     [Photo]     [DCCP]     [Netdev]     [Xorg]     [Util Linux NG]     [Xfree86]     [Free Photo Albums]     [Fedora Users]     [Fedora Women]     [ALSA Users]     [ALSA Devel]     [Linux USB]

Powered by Linux