> In the original code of video_open() there are two small bugs: > (1) the counter of the module is not incremented _before_ the > file->f_op->open(inode,file) function call, but only before > the vfl->open() one. This isn't a bug. fops_get+put handles the module reference counting. > (2) the increment of the variable vfl->users is incoherent with the > decrement of the same variable in the function video_release(). > A brief analysis of the source code and of the patch reveals > that it is so, but i will not enter into details. Please go into details, IMHO the current code is fine. > b) patch2.diff: multiple opens are allowed when the new interface > (struct file_operation*) is used; This way it should work. Gerd -- You can't please everybody. And usually if you _try_ to please everybody, the end result is one big mess. -- Linus Torvalds, 2002-04-20
